Image compare for verification set generation and oldest python workflow fix #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rification set workflow
image comparison for verification set generation
This reverts commit 9a656e0.
… works with sacct in workflow for finding failing nodes
Contributor
Author
|
I think this should be fine to merge, someone could quickly check if there are potential bash script shenanigans I'm not aware of. |
…o we take the first(oldest) if there are multiple versions available
…a substep for good measure
Fixing the workflow for testing old versions of python
lassejsc
changed the title
… calling it with old_python [Full module name for python]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making verification set, it now compares it against the previous latest verification set.
Does not produce errors if there are difference between them as the changes may be expected, does produce warnings about said changes.
Additionally added a check that all nodes run the job since we had issue of jobs failing silently. It does this by grepping
sacctforFAILEDlines.run_compare.shalso has been restructured so the verification set comparison could be added to it.Additionally fixing the oldest python workflow as I need to push it to some branch to test it easily as it is manually triggered